New API to load from CDN endpoint#106
Conversation
zhiyuanliang-ms
requested review from
Eskibear,
amerjusupovic,
avanigupta,
juniwang,
linglingye001,
mrm9084,
rossgrambo and
zhenlan
src/load.ts
Outdated
| * @param endpoint The URL to the CDN. | ||
| * @param options Optional parameters. | ||
| */ | ||
| export async function loadCdn(endpoint: URL | string, options?: AzureAppConfigurationOptions): Promise<AzureAppConfiguration>; |
There was a problem hiding this comment.
I'm wondering if it makes more sense to name it loadFromCDN insead.
There was a problem hiding this comment.
I will use camelCase, so it will be loadFromCdn
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/load-cdn
branch
from
25ae8a4 to
234ab73
Compare
src/load.ts
Outdated
| export async function loadFromCdn(endpoint: URL | string, options?: AzureAppConfigurationOptions): Promise<AzureAppConfiguration>; | ||
|
|
||
| export async function loadFromCdn( | ||
| endpoint: string | URL, |
There was a problem hiding this comment.
Do you think it will be too much to call it cdnEndpoint or it's clearer? The reason I'm asking is because we also have the other parameter appConfigOptions. Will that confuse users that it's appconfig endpoint?
There was a problem hiding this comment.
I am ok with cdnEndpoint. Updated.
src/load.ts
Outdated
| * @param cdnEndpoint The URL to the CDN. | ||
| * @param appConfigOptions Optional parameters. | ||
| */ | ||
| export async function loadFromCdn(endpoint: URL | string, options?: AzureAppConfigurationOptions): Promise<AzureAppConfiguration>; |
There was a problem hiding this comment.
endpoint
Should this be updated too?
There was a problem hiding this comment.
weird, I remembered I updated this in the commit, will update it again
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/load-cdn
branch
from
788f3e0 to
cec0605
Compare
|
Verified Azure Frond Door + sas token can get kvs from app config. So merge this PR. |
This reverts commit 6dae81a.
6 participants
No description provided.